linux-kernel - Re: [PATCH v5 10/14] serial: pic32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160416160950.GD10824@kroah.com>
Date:	Sat, 16 Apr 2016 09:09:50 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Sudeep Holla <sudeep.holla@....com>
Cc:	Joshua Henderson <joshua.henderson@...rochip.com>,
	open list <linux-kernel@...r.kernel.org>,
	linux-mips@...ux-mips.org, ralf@...ux-mips.org,
	Andrei Pistirica <andrei.pistirica@...rochip.com>,
	Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
	linux-api@...r.kernel.org
Subject: Re: [PATCH v5 10/14] serial: pic32_uart: Add PIC32 UART driver

On Fri, Apr 15, 2016 at 06:28:32PM +0100, Sudeep Holla wrote:
> Hi Greg,
> 
> I just noticed this now. I am having similar issue with MPS2 UART driver
> posted @[1], hence I am asking here to get some clarification myself.
> Sorry for replying on very old thread.
> 
> On Thu, Jan 14, 2016 at 1:15 AM, Joshua Henderson
> <joshua.henderson@...rochip.com> wrote:
> > From: Andrei Pistirica <andrei.pistirica@...rochip.com>
> >
> > This adds UART and a serial console driver for Microchip PIC32 class
> > devices.
> >
> > Signed-off-by: Andrei Pistirica <andrei.pistirica@...rochip.com>
> > Signed-off-by: Joshua Henderson <joshua.henderson@...rochip.com>
> > Cc: Ralf Baechle <ralf@...ux-mips.org>
> 
> [...]
> 
> > diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
> > index 93ba148..9df0a98 100644
> > --- a/include/uapi/linux/serial_core.h
> > +++ b/include/uapi/linux/serial_core.h
> > @@ -261,4 +261,7 @@
> >  /* STM32 USART */
> >  #define PORT_STM32     113
> >
> > +/* Microchip PIC32 UART */
> > +#define PORT_PIC32     114
> 
> This was posted before v4.6-rc1 similar to MPS2 UART and has taken
> port# 114 for it. However MVEBU UART obtained 114 with v4.6-rc1
> And MPS2 UART was assigned 115 when it got revised/reposted.
> 
> I also see this patch in linux-next with 114 itself as its port number.
> So the allocation of port number needs to be resolved before it gets
> merged or it's OK to wait for v4.7-rc1 ?
> 
> If it's former, can PORT_PIC32 take 116 as the latest post of MPS2 assigned
> it 115 and I have pulled the same to take it via arm-soc.
> 
> I am fine with any solution, just want to be notified if I need to
> take any action.

Just do the merge so the numbers are allocated in sequence.

We really need to fix this up one of these days, there's no real need
for these numbers, and it's a pain in merging, as you have found out...

thanks,

greg k-h