linux-kernel - [PATCH] irq_poll: Remove redundant barrier when using clear_bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 16 Apr 2016 10:55:36 -0700
From:	Davidlohr Bueso <dave@...olabs.net>
To:	bart.vanassche@...disk.com
Cc:	dave@...olabs.net, linux-kernel@...r.kernel.org,
	Davidlohr Bueso <dbueso@...e.de>
Subject: [PATCH] irq_poll: Remove redundant barrier when using clear_bit_unlock()

... as the call obviously already implies unlock/RC semantics,
therefore lets get rid of the superfluous smp_mb calls.

Signed-off-by: Davidlohr Bueso <dbueso@...e.de>
---
 lib/irq_poll.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/irq_poll.c b/lib/irq_poll.c
index 836f7db4e548..2a6ae2720ccb 100644
--- a/lib/irq_poll.c
+++ b/lib/irq_poll.c
@@ -50,7 +50,6 @@ EXPORT_SYMBOL(irq_poll_sched);
 static void __irq_poll_complete(struct irq_poll *iop)
 {
 	list_del(&iop->list);
-	smp_mb__before_atomic();
 	clear_bit_unlock(IRQ_POLL_F_SCHED, &iop->state);
 }
 
@@ -161,7 +160,6 @@ EXPORT_SYMBOL(irq_poll_disable);
 void irq_poll_enable(struct irq_poll *iop)
 {
 	BUG_ON(!test_bit(IRQ_POLL_F_SCHED, &iop->state));
-	smp_mb__before_atomic();
 	clear_bit_unlock(IRQ_POLL_F_SCHED, &iop->state);
 }
 EXPORT_SYMBOL(irq_poll_enable);
-- 
2.8.1