lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 Apr 2016 21:07:56 +0200 From: Neil Armstrong <narmstrong@...libre.com> To: Mathieu Poirier <mathieu.poirier@...aro.org> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, tglx@...utronix.de, Russell King <rmk+kernel@....linux.org.uk>, Sudeep Holla <sudeep.holla@....com> Subject: Re: [PATCH 1/2] clocksource: sp804: Add support for OX810SE 24bit timer width On 04/01/2016 05:33 PM, Mathieu Poirier wrote: > On 1 April 2016 at 08:22, Neil Armstrong <narmstrong@...libre.com> wrote: Hi Matthieu, Thanks for the review. >> + /* OX810SE Uses a special 24bit width */ >> + if (of_device_is_compatible(np, "oxsemi,ox810se-rps-timer")) >> + width = 24; > > Wouldn't it be better to add a new optional property for this? If the > property is not specified then we default to a width of 32. Otherwise > the new width is configured. That way we don't have to add a new > compatible string every time (however often) a special width is > encountered. As explained by Rob Herring, this HW is compatible with SP804 but is /not/ an IP from ARM and has been customized to support 24bit. Having a DT property for this width is not wanted actually since it makes no sense for the original SP804 IP, so it should be handled per vendor. > > Otherwise I think the code facelift looks good, > Mathieu Is there any other blocking points ? The point to have a change on sp804 is to economize a new very similar driver for oxnas. Neil
Powered by blists - more mailing lists