linux-kernel - Re: [RESEND PATCH v2 04/13] eeprom: at24: make locking more fine-grained

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160416205655.GB1522@katana>
Date:	Sat, 16 Apr 2016 22:56:55 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:	linux-i2c <linux-i2c@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	srinivas.kandagatla@...aro.org, maxime.ripard@...e-electrons.com,
	Andrew Lunn <andrew@...n.ch>
Subject: Re: [RESEND PATCH v2 04/13] eeprom: at24: make locking more
 fine-grained

On Mon, Apr 11, 2016 at 11:57:20AM -0700, Bartosz Golaszewski wrote:
> The only field in struct at24_data that needs locking in the module
> code is u8 *writebuf. Other data is already protected by i2c core.
> 
> Rename the lock in at24_data to wrbuf_lock and only use it where
> writebuf is accessed.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>

Did you run some tests to verify our assumption?


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)