linux-kernel - Re: [PATCH] PCI: rcar: select PCI_MSI_IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160416233321.GC15763@verge.net.au>
Date:	Sun, 17 Apr 2016 09:33:21 +1000
From:	Simon Horman <horms@...ge.net.au>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>, Rob Herring <robh@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: rcar: select PCI_MSI_IRQ_DOMAIN

On Sat, Apr 16, 2016 at 10:15:46PM +0200, Arnd Bergmann wrote:
> The R-CAR PCIe driver requires the use of irq domains for its
> MSI code:
> 
> drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_msi_irq':
> drivers/pci/host/pcie-rcar.c:635:9: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration]
> drivers/pci/host/pcie-rcar.c: In function 'rcar_msi_setup_irq':
> drivers/pci/host/pcie-rcar.c:666:8: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
> drivers/pci/host/pcie-rcar.c: In function 'rcar_pcie_enable_msi':
> drivers/pci/host/pcie-rcar.c:725:16: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration]
> drivers/pci/host/pcie-rcar.c:725:14: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
>   msi->domain = irq_domain_add_linear(pcie->dev->of_node, INT_PCI_MSI_NR,
>               ^
> drivers/pci/host/pcie-rcar.c:762:2: error: implicit declaration of function 'irq_domain_remove' [-Werror=implicit-function-declaration]
> 
> This ensures that the feature is always enabled by adding a
> Kconfig select statement. This is not consistent with what the
> other drivers do at the moment, but I have another patch that
> changes them to do it like this one, which is more logical.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

This seems reasonable to me:

Acked-by: Simon Horman <horms+renesas@...ge.net.au>

> ---
>  drivers/pci/host/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 169c545bf70a..6d642aa390b0 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -72,6 +72,8 @@ config PCI_RCAR_GEN2
>  config PCI_RCAR_GEN2_PCIE
>  	bool "Renesas R-Car PCIe controller"
>  	depends on ARCH_RENESAS || (ARM && COMPILE_TEST)
> +	select PCI_MSI
> +	select PCI_MSI_IRQ_DOMAIN
>  	help
>  	  Say Y here if you want PCIe controller support on R-Car Gen2 SoCs.
>  
> -- 
> 2.7.0
>