linux-kernel - Re: [PATCH net-next v3 4/8] net: dsa: mv88e6xxx: add switch info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k2jwmbrx.fsf@ketchup.mtl.sfl>
Date:	Sun, 17 Apr 2016 12:37:54 -0400
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...oirfairelinux.com,
	"David S. Miller" <davem@...emloft.net>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next v3 4/8] net: dsa: mv88e6xxx: add switch info

Hi Andrew,

Andrew Lunn <andrew@...n.ch> writes:

>> @@ -3100,16 +3100,19 @@ char *mv88e6xxx_drv_probe(struct device *dsa_dev, struct device *host_dev,
>>  	prod_num = (id & 0xfff0) >> 4;
>>  	rev = id & 0x000f;
>>  
>> -	name = mv88e6xxx_lookup_name(id, table, num);
>> -	if (!name)
>> +	info = mv88e6xxx_lookup_info(prod_num, table, num);
>> +	if (!info)
>>  		return NULL;
>>  
>> +	name = (char *) info->name;
>> +
>
> Hi Vivien
>
> Casting off the const is not so nice. How about adding in another
> patch to change the API to return a const char *.

OK.

Thanks,
Vivien