linux-kernel - Re: [PATCH 3/5] clocksource/drivers/mtk_timer: add _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160418164448.GB2820@linaro.org>
Date:	Mon, 18 Apr 2016 18:44:48 +0200
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	kernel-janitors@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Matthias Brugger <matthias.bgg@...il.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org,
	"Luis R . Rodriguez" <mcgrof@...nel.org>,
	Josh Triplett <josh@...htriplett.org>
Subject: Re: [PATCH 3/5] clocksource/drivers/mtk_timer: add __init attribute

On Mon, Apr 18, 2016 at 04:55:36PM +0200, Julia Lawall wrote:
> Add __init attribute on a function that is only called from other __init
> functions and that is not inlined, at least with gcc version 4.8.4 on an
> x86 machine with allyesconfig.  Currently, the function is put in the
> .text.unlikely segment.  Declaring it as __init will cause it to be put in
> the .init.text and to disappear after initialization.
> 
> The result of objdump -x on the function before the change is as follows:
> 
> 0000000000000000 l     F .text.unlikely 000000000000006f mtk_timer_setup.isra.4
> 
> And after the change it is as follows:
> 
> 0000000000000000 l     F .init.text	000000000000006a mtk_timer_setup.isra.4
> 
> Done with the help of Coccinelle.  The semantic patch checks for local
> static non-init functions that are called from an __init function and are
> not called from any other function.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> ---

Applied for 4.7.

Thanks !

  -- Daniel