linux-kernel - Re: [PATCH v4] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 Apr 2016 18:22:03 +0100
From:	Mark Brown <broonie@...nel.org>
To:	PC Liao <pc.liao@...iatek.com>
Cc:	tiwai@...e.de, srv_heupstream@...iatek.com,
	linux-mediatek@...ts.infradead.org, s.hauer@...gutronix.de,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org, koro.chen@...iatek.com
Subject: Re: [PATCH v4] ASoC: mediatek: Add second I2S on mt8173-rt5650
 machine driver

On Mon, Apr 18, 2016 at 08:43:39PM +0800, PC Liao wrote:

> +Optional properties:
> +- sound-dai: audio codec dai on capture path
> +  <&rt5650 0> : Default setting. Connect rt5650 I2S1 for capture. (dai_name = rt5645-aif1)
> +  <&rt5650 1> : Connect rt5650 I2S2 for capture. (dai_name = rt5645-aif2)

Code-wise this seems fine but it seems like it'd be clearer to call this
capture-dai - this isn't used to select whatr's used for playback, only
for capture.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)