linux-kernel - [PATCH 2/5] input: twl6040-vibra: add handler to unregister input if module is removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Apr 2016 21:55:38 +0200
From:	"H. Nikolaus Schaller" <hns@...delico.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Peter Ujfalusi <peter.ujfalusi@...com>,
	"H. Nikolaus Schaller" <hns@...delico.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...a-handheld.com, letux-kernel@...nphoenux.org
Subject: [PATCH 2/5] input: twl6040-vibra: add handler to unregister input if module is removed

commit 1f9e1470ab34 ("Input: twl6040-vibra - use devm functions")

converted everything to devm but we still need to call
input_unregister_device(info->input_dev)

Solution: add back twl6040_vibra_remove to call input_unregister_device

Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
---
 drivers/input/misc/twl6040-vibra.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c
index 7221a00..1e9902d 100644
--- a/drivers/input/misc/twl6040-vibra.c
+++ b/drivers/input/misc/twl6040-vibra.c
@@ -384,8 +384,18 @@ static int twl6040_vibra_probe(struct platform_device *pdev)
 	return 0;
 }
 
+static int twl6040_vibra_remove(struct platform_device *pdev)
+{
+	struct vibra_info *info = platform_get_drvdata(pdev);
+
+	input_unregister_device(info->input_dev);
+
+	return 0;
+	}
+
 static struct platform_driver twl6040_vibra_driver = {
 	.probe		= twl6040_vibra_probe,
+	.remove		= twl6040_vibra_remove,
 	.driver		= {
 		.name	= "twl6040-vibra",
 		.pm	= &twl6040_vibra_pm_ops,
-- 
2.7.3