linux-kernel - Re: [PART1 RFC v4 01/11] KVM: x86: Misc LAPIC changes to expose helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57153C18.6020104@amd.com>
Date:	Tue, 19 Apr 2016 02:57:12 +0700
From:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
To:	Radim Krčmář <rkrcmar@...hat.com>
CC:	<pbonzini@...hat.com>, <joro@...tes.org>, <bp@...en8.de>,
	<gleb@...nel.org>, <alex.williamson@...hat.com>,
	<kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<wei@...hat.com>, <sherry.hurwitz@....com>
Subject: Re: [PART1 RFC v4 01/11] KVM: x86: Misc LAPIC changes to expose
 helper functions

Radim,

On 04/12/2016 03:34 AM, Radim Krčmář wrote:
> 2016-04-07 03:20-0500, Suravee Suthikulpanit:
>> Exporting LAPIC utility functions and macros for re-use in SVM code.
>>
>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
>> ---
>
> Adding kvm_lapic_set_reg looks weird when KVM has kvm_apic_get_reg, but
> the structure they accept is called kvm_lapic, so I vote to rename get,
>
> Reviewed-by: Radim Krčmář <rkrcmar@...hat.com>
>

Sure. Within the same patch, I can rename kvm_apic_get_reg to 
kvm_lapic_get_reg to be consistent.

Thanks,
Suravee