linux-kernel - Re: [PATCH 4/5] input: twl6040-vibra: ignore return value of schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160418214743.GE1006@dtor-ws>
Date:	Mon, 18 Apr 2016 14:47:43 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	"H. Nikolaus Schaller" <hns@...delico.com>
Cc:	Fabio Estevam <fabio.estevam@...escale.com>,
	Peter Ujfalusi <peter.ujfalusi@...com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...a-handheld.com, letux-kernel@...nphoenux.org
Subject: Re: [PATCH 4/5] input: twl6040-vibra: ignore return value of
 schedule_work

On Mon, Apr 18, 2016 at 09:55:40PM +0200, H. Nikolaus Schaller wrote:
> returning ret is wrong. And checking for an error as well. User space
> may call multiple times until the work is really scheduled.
> 
> twl4030-vibra.c also ignores the return value.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>

Applied, thank you.

> ---
>  drivers/input/misc/twl6040-vibra.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c
> index 3805129..69c5940 100644
> --- a/drivers/input/misc/twl6040-vibra.c
> +++ b/drivers/input/misc/twl6040-vibra.c
> @@ -212,11 +212,7 @@ static int vibra_play(struct input_dev *input, void *data,
>  	info->strong_speed = effect->u.rumble.strong_magnitude;
>  	info->direction = effect->direction < EFFECT_DIR_180_DEG ? 1 : -1;
>  
> -	ret = schedule_work(&info->play_work);
> -	if (!ret) {
> -		dev_info(&input->dev, "work is already on queue\n");
> -		return ret;
> -	}
> +	schedule_work(&info->play_work);
>  
>  	return 0;
>  }
> -- 
> 2.7.3
> 

-- 
Dmitry