lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Apr 2016 16:42:15 -0600 From: Sagar Dharia <sdharia@...eaurora.org> To: Mark Brown <broonie@...nel.org> Cc: robh@...nel.org, gregkh@...uxfoundation.org, bp@...e.de, poeschel@...onage.de, treding@...dia.com, gong.chen@...ux.intel.com, andreas.noever@...il.com, alan@...ux.intel.com, mathieu.poirier@...aro.org, daniel@...ll.ch, oded.gabbay@....com, jkosina@...e.cz, sharon.dvir1@...l.huji.ac.il, joe@...ches.com, davem@...emloft.net, james.hogan@...tec.com, michael.opdenacker@...e-electrons.com, daniel.thompson@...aro.org, robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com, ijc+devicetree@...lion.org.uk, galak@...eaurora.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, kheitke@...ience.com, mlocke@...eaurora.org, agross@...eaurora.org, linux-arm-msm@...r.kernel.org Subject: Re: [PATCH V4 4/6] slim: qcom: Add Qualcomm Slimbus controller driver On 4/18/2016 3:19 AM, Mark Brown wrote: > On Fri, Apr 15, 2016 at 10:17:36AM -0600, Sagar Dharia wrote: > > Please leave blank lines between paragraphs, it makes things much easier > to read than a wall of uninterrupted text. > >>>> + ret = devm_request_irq(&pdev->dev, dev->irq, msm_slim_interrupt, >>>> + IRQF_TRIGGER_HIGH, "msm_slim_irq", dev); >>>> + if (ret) { >>>> + dev_err(&pdev->dev, "request IRQ failed\n"); >>>> + goto err_request_irq_failed; >>>> + } >>> Are you sure this is safe and we don't deallocate things the interrupt >>> handler uses before we disable the interrupt? >> Since clock is not enabled before this step, we won't be getting any >> interrupts from HW at this stage. > No, that's not what I'm saying - I'm asking about the *disable* path on > remove. Good point, I will change the del_controller as well to enter clock-pause, and the controller's remove function to disable interrupt. Thanks Sagar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Powered by blists - more mailing lists