linux-kernel - Re: [PATCH 2/2] Staging: Lustre: Fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1460969256.19090.110.camel@perches.com>
Date:	Mon, 18 Apr 2016 01:47:36 -0700
From:	Joe Perches <joe@...ches.com>
To:	"Drokin, Oleg" <oleg.drokin@...el.com>,
	Panos Vlachos <panosvlchs@...il.com>
Cc:	"<devel@...verdev.osuosl.org>" <devel@...verdev.osuosl.org>,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
	"Dilger, Andreas" <andreas.dilger@...el.com>
Subject: Re: [PATCH 2/2] Staging: Lustre: Fixed coding style issues

On Sun, 2016-04-17 at 21:35 +0000, Drokin, Oleg wrote:
> On Apr 17, 2016, at 10:11 AM, Panos Vlachos wrote:
> > Fixed one coding style issue in the
> > file router_proc.c (Lustre staging driver)
> Perhaps it's best to reference what the issue is.
> I.e. "Fix too long line in …"
> and then in the actual message add that you just split it?
[]
> > diff --git a/drivers/staging/lustre/lnet/lnet/router_proc.c b/drivers/staging/lustre/lnet/lnet/router_proc.c
[]
> > @@ -32,7 +32,8 @@
> >  */
> > #define LNET_PROC_CPT_BITS	(LNET_CPT_BITS + 1)
> > /* change version, 16 bits or 8 bits */
> > -#define LNET_PROC_VER_BITS	max_t(size_t, min_t(size_t, LNET_LOFFT_BITS, 64) / 4, 8)
> > +#define LNET_PROC_VER_BITS	\
> > +max_t(size_t, min_t(size_t, LNET_LOFFT_BITS, 64) / 4, 8)
> Hm, I am not sure this is an improvement, you might want to at least place a tab at the start of this
> second line, so that indentation helps us better see it's a continuation of the previous one.

Given:
	#define LNET_LOFFT_BITS          (sizeof(loff_t) * 8)
and:
	include/linux/types.h:typedef __kernel_loff_t           loff_t;
	include/uapi/asm-generic/posix_types.h:typedef long long        __kernel_loff_t;

and this isn't going to change any time soon,
maybe this #define isn't particularly useful and

	#define LNET_PROC_VER_BITS	16

is sufficient.