linux-kernel - Re: [PATCH] regulator: s2mps11: Remove unused set_voltage_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160418095713.GO3217@sirena.org.uk>
Date:	Mon, 18 Apr 2016 10:57:13 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Sangbeom Kim <sbkim73@...sung.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel

On Mon, Apr 18, 2016 at 09:42:58AM +0200, Krzysztof Kozlowski wrote:

> On S2MPS11 and S2MPS14 devices the default implementation of
> set_voltage_time_sel() for LDO regulators was not doing anything useful
> because users did not provide ramp delay in Device Tree so the
> set_voltage_time_sel() exited with status 0. This could be seen in
> dmesg, e.g. on Odroid XU4:

That's not the bug, the bug is that the driver is providing the
operation without providing a non-zero value for it.  The device tree
configuration is to override what the driver is doing.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)