linux-kernel - Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5714B0D4.7080506@rock-chips.com>
Date:	Mon, 18 Apr 2016 18:03:00 +0800
From:	Xing Zheng <zhengxing@...k-chips.com>
To:	Mark Brown <broonie@...nel.org>
CC:	linux-rockchip@...ts.infradead.org, heiko@...ech.de,
	Adam.Thomson@...semi.com, sugar.zhang@...k-chips.com,
	jay.xu@...k-chips.com, Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec

HI Mark,

On 2016年04月18日 17:53, Mark Brown wrote:
> On Mon, Apr 18, 2016 at 05:43:51PM +0800, Xing Zheng wrote:
>
>> The patch_1/3 add an export of a function that calls the _detect_jack_
>> function
>> when a codec supports jack detection and fill the _detect_jack_ function in
>> the
>> struct snd_soc_codec_driver.
> But why would anything ever call this function?  How is this supposed to
> be used?
In my opinion, this function is mainly to provide simple-card (patch_2/3).

This function will call and initialize jack detection if a codec 
supports it and fill the detect_jack function (patch_3/3 use it),
and, we don't need to create a customized machine driver to call the 
codec jack detection, the simple-card is able to
parse them.

Thanks.

-- 
- Xing Zheng