linux-kernel - Re: [PATCH] dspi: config dspi master regmap with right mode depend on BE or LE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160418101117.GP3217@sirena.org.uk>
Date:	Mon, 18 Apr 2016 11:11:17 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Scott Wood <scott.wood@....com>
Cc:	Po Liu <po.liu@....com>,
	"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dspi: config dspi master regmap with right mode depend
 on BE or LE

On Sun, Apr 17, 2016 at 02:41:40AM +0000, Scott Wood wrote:

> Looking more closely, the binding has a big-endian property.  It says
> the default if that property is absent is native endian, which is
> insane.  Fix the binding to say that little endian is the default (this
> change shouldn't break any existing trees), and make sure that's what
> the code implements.  I think you need val_format_endian_default, not
> val_format_endian.

The binding defaults to little endian and (in implmentation terms)
always has done though that used to be unintentional.  There *are* a
reasonable number of devices out there which are native endian, for
example most of the MIPS chips switch the endianness of the entire chip
rather than just the CPU, but most of the current usage has been on ARM
devices which only switch the core.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)