linux-kernel - Re: [PATCH v4 0/3] mmc: pwrseq: convert to proper driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFpDurzJdJP17knVwpRn-q+xQv=fkEgCP1R=S5PMTWYAQg@mail.gmail.com>
Date:	Mon, 18 Apr 2016 13:21:07 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Martin Fuzzey <mfuzzey@...keon.com>
Subject: Re: [PATCH v4 0/3] mmc: pwrseq: convert to proper driver

On 14 April 2016 at 15:02, Srinivas Kandagatla
<srinivas.kandagatla@...aro.org> wrote:
> Thanks for reviewing v3.
>
> This patchset aims at converting the pwrseq devices to proper in drivers,
> The issue is that on Qualcomm based platforms, most of the gpios require
> a pinctrl setup. Existing pwrseq code does not do any kind of pinctrl setup.
> So this makes the pwrseq unusable on those platfroms.
>
> Convert the pwrseq to proper drivers so that they can reuse
> common driver setup like pinctrl from drivers/base/pinctrl.c and clocks.
> This solution works much better and would make pwrseq to reuse
> all the driver setup done in the common code.
>
> Changes since v3:
>         - Add error handling for try_module_get failures, suggested by Ulf.
>
> Changes since v2: All changes suggested by Ulf
>         - Moved all the allocations/gpio_get/clk_get to probe
>         - Removed alloc and free callbacks
>         - try_get_module inside a mutex
>         - Fixed Kconfigs
>         - renamed list to pwrseq_node
>         - add mssing pdev_set_drvdata()
>
> Changes since v1:
>         - Fixed issue while building as module.
>
> Changes since RFC:
>         - Fixed issues reported by kbuild test robot.
>         - return EPROBE_DEFER from *_alloc() suggested by Ulf.
>
> Thanks,
> srini
>
> Srinivas Kandagatla (3):
>   mmc: pwrseq_simple: add to_pwrseq_simple() macro
>   mmc: pwrseq_emmc: add to_pwrseq_emmc() macro
>   mmc: pwrseq: convert to proper platform device
>
>  drivers/mmc/core/Kconfig         |  21 ++++++++
>  drivers/mmc/core/Makefile        |   4 +-
>  drivers/mmc/core/pwrseq.c        | 108 ++++++++++++++++++---------------------
>  drivers/mmc/core/pwrseq.h        |  19 ++++---
>  drivers/mmc/core/pwrseq_emmc.c   |  81 ++++++++++++++++++-----------
>  drivers/mmc/core/pwrseq_simple.c |  91 ++++++++++++++++++---------------
>  6 files changed, 185 insertions(+), 139 deletions(-)
>
> --
> 2.5.0
>

Thanks, applied for next!

Kind regards
Uffe