linux-kernel - Re: [PATCH for-next] spi: bcm53xx: add spi_flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160418112457.GU3217@sirena.org.uk>
Date:	Mon, 18 Apr 2016 12:24:57 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	"open list:SPI SUBSYSTEM" <linux-spi@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH for-next] spi: bcm53xx: add spi_flash_read callback for
 MMIO-based reads

On Mon, Apr 18, 2016 at 01:10:43PM +0200, Rafał Miłecki wrote:

> +static int bcm53xxspi_flash_read(struct spi_device *spi,
> +				 struct spi_flash_read_message *msg)
> +{
> +	struct bcm53xxspi *b53spi = spi_master_get_devdata(spi->master);
> +	int ret = 0;
> +
> +	bcm53xxspi_enable_bspi(b53spi);
> +	memcpy_fromio(msg->buf, b53spi->mmio_base + msg->from, msg->len);
> +	msg->retlen = msg->len;

There's no bounds check here but...

> +	if (core->addr_s[0])
> +		b53spi->mmio_base = devm_ioremap(dev, core->addr_s[0], SZ_32M);

...we only mapped 32M here.  What if something tries to do a larger
read?  It's also a bit surprising that we're mapping a specific size
here rather than the entire resource.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)