linux-kernel - Re: [patch -next] udp: fix if statement in SIOCINQ ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-J3D4HntLHfLjT7_9oj+nWqXjBww3SdNDDSsQxpvfwiUQ@mail.gmail.com>
Date:	Mon, 18 Apr 2016 09:41:03 -0400
From:	Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Willem de Bruijn <willemb@...gle.com>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>,
	Network Development <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch -next] udp: fix if statement in SIOCINQ ioctl

On Mon, Apr 18, 2016 at 8:19 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Mon, 2016-04-18 at 11:44 +0300, Dan Carpenter wrote:
>> We deleted a line of code and accidentally made the "return put_user()"
>> part of the if statement when it's supposed to be unconditional.
>>
>> Fixes: 9f9a45beaa96 ('udp: do not expect udp headers on ioctl SIOCINQ')
>> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>

Thanks for catching this.