linux-kernel - Re: [RFC PATCH 0/2] s390/klp: s390 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160418151754.etezfmuv7jk4uf5w@treble>
Date:	Mon, 18 Apr 2016 10:17:54 -0500
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Miroslav Benes <mbenes@...e.cz>
Cc:	jikos@...nel.org, jeyu@...hat.com, linux-kernel@...r.kernel.org,
	live-patching@...r.kernel.org, vojtech@...e.com, jslaby@...e.cz,
	pmladek@...e.cz
Subject: Re: [RFC PATCH 0/2] s390/klp: s390 support

On Mon, Apr 18, 2016 at 05:01:08PM +0200, Miroslav Benes wrote:
> So this is something we have in kGraft for a while (though the actual
> implementation in s390's entry.S differs).
> 
> The first patch is needed because we want our TIF flag to be part of
> _TIF_WORK and s390's tm instruction tests only 8-bits.
> 
> The second patch adds a call to klp_update_task_universe() to entry.S.
> Specifically to syscall and interrupt return paths.
> 
> WARNING: It is only compile-tested. It even cannot be linked, because
> klp_update_task_universe() is static inline. Josh, you're gonna change
> this part anyway to remove TIF_KLP_NEED_UPDATE from arch-independent
> code, aren't you? 
> 
> Comments are obviously welcome. s390 maintainters not CC'ed yet.
> 
> Jiri Slaby (1):
>   s390: livepatch, reorganize TIF bits
> 
> Miroslav Benes (1):
>   s390/klp: update task universe when exiting kernel
> 
>  arch/s390/include/asm/thread_info.h | 24 ++++++++++++++++--------
>  arch/s390/kernel/entry.S            | 31 ++++++++++++++++++++++++++++++-
>  2 files changed, 46 insertions(+), 9 deletions(-)

Yeah, I think I will need to do something like change
klp_update_task_universe() to be non-inline.  Thanks a lot for the code!

-- 
Josh