linux-kernel - Re: [PATCH 3/6] leds: pca963x: Add defines and remove some magic values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201604191636.GDE1OrKw%fengguang.wu@intel.com>
Date:	Tue, 19 Apr 2016 16:16:30 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Olliver Schinagl <oliver@...inagl.nl>
Cc:	kbuild-all@...org, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Richard Purdie <rpurdie@...ys.net>,
	Jacek Anaszewski <j.anaszewski@...sung.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-leds@...r.kernel.org, Olliver Schinagl <oliver@...inagl.nl>
Subject: Re: [PATCH 3/6] leds: pca963x: Add defines and remove some magic
 values

Hi,

[auto build test ERROR on j.anaszewski-leds/for-next]
[also build test ERROR on v4.6-rc4 next-20160419]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Olliver-Schinagl/leds-pca9653x-support-inverted-outputs-and-cleanups/20160419-154536
base:   https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds for-next
config: x86_64-randconfig-x010-201616 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the linux-review/Olliver-Schinagl/leds-pca9653x-support-inverted-outputs-and-cleanups/20160419-154536 HEAD 08d56036eb1d895519b5f9589b55341bed74f121 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/leds/leds-pca963x.c: In function 'pca963x_brightness':
>> drivers/leds/leds-pca963x.c:220:4: error: 'PCA963X_PWM_BASE' undeclared (first use in this function)
       PCA963X_PWM_BASE + pca963x->led_num,
       ^
   drivers/leds/leds-pca963x.c:220:4: note: each undeclared identifier is reported only once for each function it appears in

vim +/PCA963X_PWM_BASE +220 drivers/leds/leds-pca963x.c

75cb2e1d drivers/leds/leds-pca9633.c Peter Meerwald          2012-03-23  214  	case LED_OFF:
5029a2e3 drivers/leds/leds-pca963x.c Andrew Lunn             2015-08-20  215  		ret = i2c_smbus_write_byte_data(pca963x->chip->client,
5029a2e3 drivers/leds/leds-pca963x.c Andrew Lunn             2015-08-20  216  			ledout_addr, ledout & ~mask);
75cb2e1d drivers/leds/leds-pca9633.c Peter Meerwald          2012-03-23  217  		break;
75cb2e1d drivers/leds/leds-pca9633.c Peter Meerwald          2012-03-23  218  	default:
5029a2e3 drivers/leds/leds-pca963x.c Andrew Lunn             2015-08-20  219  		ret = i2c_smbus_write_byte_data(pca963x->chip->client,
56a1740c drivers/leds/leds-pca963x.c Ricardo Ribalda Delgado 2013-08-14 @220  			PCA963X_PWM_BASE + pca963x->led_num,
5029a2e3 drivers/leds/leds-pca963x.c Andrew Lunn             2015-08-20  221  			brightness);
5029a2e3 drivers/leds/leds-pca963x.c Andrew Lunn             2015-08-20  222  		if (ret < 0)
5029a2e3 drivers/leds/leds-pca963x.c Andrew Lunn             2015-08-20  223  			goto unlock;

:::::: The code at line 220 was first introduced by commit
:::::: 56a1740c21e4396164265c3ec80e29990ddcdc36 leds-pca9633: Rename to leds-pca963x

:::::: TO: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
:::::: CC: Bryan Wu <cooloney@...il.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (23708 bytes)