linux-kernel - Re: [PATCH 1/2] mmc: core: Improve marking broken HPI through devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFrhyqHYmSjrC23bHOkkz2F0QJGwbDKyryfEmoJhwkgMtg@mail.gmail.com>
Date:	Tue, 19 Apr 2016 11:51:00 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Olliver Schinagl <oliver@...inagl.nl>
Cc:	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Chen-Yu Tsai <wens@...e.org>,
	Venu Byravarasu <vbyravarasu@...dia.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Michal Hocko <mhocko@...e.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Sudeep Holla <Sudeep.Holla@....com>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Wenkai Du <wenkai.du@...el.com>,
	Chaotian Jing <chaotian.jing@...iatek.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Jaehoon Chung <jh80.chung@...sung.com>,
	Michal Suchanek <hramrach@...il.com>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/2] mmc: core: Improve marking broken HPI through devicetree

On 19 April 2016 at 11:42, Olliver Schinagl <oliver@...inagl.nl> wrote:
> Hi Ulf,
>
> On 19-04-16 11:29, Ulf Hansson wrote:
>>
>> On 19 April 2016 at 09:12, Olliver Schinagl <oliver@...inagl.nl> wrote:
>>>
>>> In patch 81f8a7be66 Hans de Goede added a patch to allow marking an mmc
>>> device as to having an broken HPI implementation. After talking some
>>> with Hans, we now think it is actually the mmc controller that can be
>>> broken and not support broken HPI's.
>>
>> I don't want us to invent a DT binding for something you *think* is a
>> HW controller issue.
>>
>> Have you really excluded that this isn't a software issue? Me
>> personally haven't been using HPI that much so I can't really tell
>> about the code robustness from the mmc core (mmc protocol point of
>> view).
>
> Well this patch goes hand in hand so to speak with the broken-hpi patch
> introduced by him, he did most of the investigation. We just discussed how
> to handle it and asked me to cook up the patch.

Well, my point is that it's more understandable about having a broken
HPI implementation for eMMC cards, but for host controllers I am not
so sure.

I don't think there is an electrical change required by the host
controller to support HPI, is just like any other command, right?
Unless I am missing something, of course.

Kind regards
Uffe