lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Apr 2016 13:00:38 +0300 From: "Michael S. Tsirkin" <mst@...hat.com> To: Pan Xinhui <xinhui@...ux.vnet.ibm.com> Cc: linux-kernel@...r.kernel.org, ysato@...rs.sourceforge.jp, dalias@...c.org, peterz@...radead.org, linux-sh@...r.kernel.org Subject: Re: [PATCH] sh: cmpxchg: fix a bit shift bug in big_endian os On Tue, Apr 19, 2016 at 02:58:53PM +0800, Pan Xinhui wrote: > From: Pan Xinhui <xinhui.pan@...ux.vnet.ibm.com> > > Correct bitoff in big endian OS. > > Fixes: 3226aad81aa6 ("sh: support 1 and 2 byte xchg") > Signed-off-by: Pan Xinhui <xinhui.pan@...ux.vnet.ibm.com> I would add: current code works correctly for 1 byte but not for 2 bytes. Acked-by: Michael S. Tsirkin <mst@...hat.com> > --- > arch/sh/include/asm/cmpxchg-xchg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sh/include/asm/cmpxchg-xchg.h b/arch/sh/include/asm/cmpxchg-xchg.h > index 7219719..1e881f5 100644 > --- a/arch/sh/include/asm/cmpxchg-xchg.h > +++ b/arch/sh/include/asm/cmpxchg-xchg.h > @@ -21,7 +21,7 @@ static inline u32 __xchg_cmpxchg(volatile void *ptr, u32 x, int size) > int off = (unsigned long)ptr % sizeof(u32); > volatile u32 *p = ptr - off; > #ifdef __BIG_ENDIAN > - int bitoff = (sizeof(u32) - 1 - off) * BITS_PER_BYTE; > + int bitoff = (sizeof(u32) - size - off) * BITS_PER_BYTE; > #else > int bitoff = off * BITS_PER_BYTE; > #endif > -- > 1.9.1
Powered by blists - more mailing lists