linux-kernel - Re: [PATCH 3/3] nvmem: imx-ocotp: handling clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Apr 2016 07:42:17 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Peng Fan <van.freenix@...il.com>
Cc:	Shawn Guo <shawnguo@...nel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 3/3] nvmem: imx-ocotp: handling clock

Hi Peng,

On Tue, Apr 19, 2016 at 5:33 AM, Peng Fan <van.freenix@...il.com> wrote:

> @@ -46,11 +48,15 @@ static int imx_ocotp_read(void *context, const void *reg, size_t reg_size,
>         if (count > (priv->nregs - index))
>                 count = priv->nregs - index;
>
> +       clk_prepare_enable(priv->clk);

clk_prepare_enable() may fail, so you should better check its return
value and propagate it in the case of error.