linux-kernel - Re: [RFC] iio: st: Add lsm9ds0 support for gyro accel and magny

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57160E37.2040401@intel.com>
Date:	Tue, 19 Apr 2016 13:53:43 +0300
From:	Crestez Dan Leonard <leonard.crestez@...el.com>
To:	Lucas De Marchi <lucas.de.marchi@...il.com>,
	Jonathan Cameron <jic23@...nel.org>
Cc:	Denis Ciocca <denis.ciocca@...com>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Giuseppe BARBA <giuseppe.barba@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	Daniel Baluta <daniel.baluta@...el.com>,
	Peter Rosin <peda@...ator.liu.se>,
	Wolfram Sang <wsa@...-dreams.de>
Subject: Re: [RFC] iio: st: Add lsm9ds0 support for gyro accel and magny

On 04/19/2016 08:10 AM, Lucas De Marchi wrote:
> On Mon, Apr 18, 2016 at 4:51 PM, Jonathan Cameron <jic23@...nel.org> wrote:
>> On 18/04/16 11:25, Crestez Dan Leonard wrote:
>>> On 04/18/2016 09:07 AM, Denis Ciocca wrote:
>>> Then st_combo_* implementation functions would forward to st_magn_* or
>>> st_accel_* depending on chan->type. Does this make sense?
>> Perhaps. If you have a short term need for this perhaps Denis and you can
>> work together to speed up what he has 'in the works' for this?
>> No point in duplicating work!
>>
>> The gyro element can go forward separately in the meantime.
> 
> Isn't LSM9DS0 just a package of LSM303D and L3GD20 that could reuse
> the drivers already present?

That doesn't seem to be mentioned in the datasheets but I guessed that
is a repacking of existing devices.

The gyro part of the patch only adds IDs. It's ~10 lines spread around
many files.

For accel/magn parts there is a WHOAMI different from all others present
and some registers also seem to be different. There doesn't seem to be
explicit support for "LSM303D".

I have no urgent need for this to work, I'm fine with waiting some time
for st_sensor combo support.

I can repost the gyro and accel+magn parts separately. But it's not
clear that supporting an accel-only device would still make sense once
combo support is available. So maybe I should just repost the gyro patch
adding IDs?

Regards,
Leonard