linux-kernel - Re: [RFC] DMA initialization for manually created devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1461068047.3765.97.camel@infradead.org>
Date:	Tue, 19 Apr 2016 08:14:07 -0400
From:	David Woodhouse <dwmw2@...radead.org>
To:	Felipe Balbi <felipe.balbi@...ux.intel.com>,
	Vinod Koul <vinod.koul@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [RFC] DMA initialization for manually created devices

On Tue, 2016-04-19 at 14:38 +0300, Felipe Balbi wrote:
> 
> The reason for that I'm using a manually created platform_device and
> that misses dev->archdata which the underlying/parent PCI device has.

Typically we'd expect you to use the parent device for DMA, as in your
second option.

That said, we're exploring the option of moving the dma_ops to be a
first-class member of 'struct device' instead of hiding it in archdata,
and cleaning up the way that it gets initialised for newly-created
devices. And at that point we might end up letting it get inherited
from the parent so your original code *would* work... but I wouldn't
hold your breath for that.

Definitely *don't* mess around in archdata.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5691 bytes)