linux-kernel - Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57162877.3010508@nvidia.com>
Date:	Tue, 19 Apr 2016 18:15:43 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Thierry Reding <thierry.reding@...il.com>
CC:	<linus.walleij@...aro.org>, <gnurou@...il.com>,
	<swarren@...dotorg.org>, <linux-gpio@...r.kernel.org>,
	<linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce


On Tuesday 19 April 2016 06:07 PM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Tue, Apr 19, 2016 at 03:13:40PM +0530, Laxman Dewangan wrote:
> [...]
>> @@ -570,7 +612,14 @@ static struct tegra_gpio_soc_config tegra30_gpio_config = {
>>   	.upper_offset = 0x80,
>>   };
>>   
>> +static struct tegra_gpio_soc_config tegra210_gpio_config = {
>> +	.bank_stride = 0x100,
>> +	.upper_offset = 0x80,
>> +	.debounce_supported = true,
>> +};
>> +
>>   static const struct of_device_id tegra_gpio_of_match[] = {
>> +	{ .compatible = "nvidia,tegra210-gpio", .data = &tegra210_gpio_config },
>>   	{ .compatible = "nvidia,tegra30-gpio", .data = &tegra30_gpio_config },
>>   	{ .compatible = "nvidia,tegra20-gpio", .data = &tegra20_gpio_config },
>>   	{ },
> I think I'd split this hunk off into a separate patch. Oh, and perhaps
> follow up with a patch that makes the SoC configuration data const?
>

OK, then I will do that on follow-on patch:
- Get rid of all global variables.
- Convert the soc config to the constant.