[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5716326B.2040403@intel.com>
Date: Tue, 19 Apr 2016 16:28:11 +0300
From: Adrian Hunter <adrian.hunter@...el.com>
To: Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc: linux-mmc <linux-mmc@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH 1/7] mmc: sdhci-pltfm: bail out if register resource is
too small
On 19/04/16 14:46, Masahiro Yamada wrote:
> Hi Adrian,
>
>
> 2016-04-19 20:32 GMT+09:00 Adrian Hunter <adrian.hunter@...el.com>:
>> On 14/04/16 05:29, Masahiro Yamada wrote:
>>> This code checks the resource size and displays an error message if
>>> it is too small, but still moves forward. Let is fail in that case.
>>
>> is -> it
>>
>> How do you know there aren't drivers that actually have a smaller size?
>
> No, I do not know.
>
> This is an error message, so I think it should fail in that case.
>
>
> Maybe, can we drop this check completely?
Yes, I think so.
Powered by blists - more mailing lists