linux-kernel - Re: [PATCH] efi: ARM: avoid warning about phys_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160419134616.GD21110@arm.com>
Date:	Tue, 19 Apr 2016 14:46:17 +0100
From:	Will Deacon <will.deacon@....com>
To:	Matt Fleming <matt@...eblueprint.co.uk>
Cc:	Arnd Bergmann <arnd@...db.de>, Steve Capper <steve.capper@....com>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	David Daney <david.daney@...ium.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Mark Rutland <mark.rutland@....com>,
	Leif Lindholm <leif.lindholm@...aro.org>,
	Dan Williams <dan.j.williams@...el.com>,
	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] efi: ARM: avoid warning about phys_addr_t cast

On Mon, Apr 18, 2016 at 10:12:33PM +0100, Matt Fleming wrote:
> On Mon, 18 Apr, at 10:34:19AM, Arnd Bergmann wrote:
> > memblock_remove() takes a phys_addr_t, which may be narrower than 64 bits,
> > causing a harmless warning:
> > 
> > drivers/firmware/efi/arm-init.c: In function 'reserve_regions':
> > include/linux/kernel.h:29:20: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
> >  #define ULLONG_MAX (~0ULL)
> >                     ^
> > drivers/firmware/efi/arm-init.c:152:21: note: in expansion of macro 'ULLONG_MAX'
> >   memblock_remove(0, ULLONG_MAX);
> > 
> > This adds an explicit typecast to avoid the warning
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Fixes: 500899c2cc3e ("efi: ARM/arm64: ignore DT memory nodes instead of removing them")
> > ---
> >  drivers/firmware/efi/arm-init.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Will, this one is for you.
> 
> Reviewed-by: Matt Fleming <matt@...eblueprint.co.uk>

Thanks, I'll throw it on the pile.

Will