linux-kernel - Re: [PATCH] drivers: firmware: psci: add __init mark to psci_dt_cpu_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Apr 2016 16:05:55 +0100
From:	Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:	Jisheng Zhang <jszhang@...vell.com>
Cc:	mark.rutland@....com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: firmware: psci: add __init mark to
 psci_dt_cpu_init_idle

Hi Jisheng,

On Tue, Mar 22, 2016 at 10:35:29PM +0800, Jisheng Zhang wrote:
> psci_dt_cpu_init_idle() and psci_cpu_init_idle() are not needed after
> booting, so mark them as __init.
> 
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>
> ---

I've slightly changed the $SUBJECT, patch below FYI.

Lorenzo

-- >8 --
Subject: [PATCH] drivers: firmware: psci: mark idle init functions __init

psci_dt_cpu_init_idle() and psci_cpu_init_idle() are not needed after
booting, so mark them as __init.

Signed-off-by: Jisheng Zhang <jszhang@...vell.com>
[lpieralisi: updated patch subject]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
---
 drivers/firmware/psci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/psci.c b/drivers/firmware/psci.c
index 6d86881..4a6a7de 100644
--- a/drivers/firmware/psci.c
+++ b/drivers/firmware/psci.c
@@ -250,7 +250,7 @@ static int __init psci_features(u32 psci_func_id)
 #ifdef CONFIG_CPU_IDLE
 static DEFINE_PER_CPU_READ_MOSTLY(u32 *, psci_power_state);
 
-static int psci_dt_cpu_init_idle(struct device_node *cpu_node, int cpu)
+static int __init psci_dt_cpu_init_idle(struct device_node *cpu_node, int cpu)
 {
 	int i, ret, count = 0;
 	u32 *psci_states;
@@ -310,7 +310,7 @@ free_mem:
 	return ret;
 }
 
-int psci_cpu_init_idle(unsigned int cpu)
+int __init psci_cpu_init_idle(unsigned int cpu)
 {
 	struct device_node *cpu_node;
 	int ret;