linux-kernel - Re: [PATCH v2 1/1] powerpc/86xx: Add support for Emerson/Artesyn MVME7100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1461101600.32510.207.camel@buserror.net>
Date:	Tue, 19 Apr 2016 16:33:20 -0500
From:	Scott Wood <oss@...error.net>
To:	Alessio Igor Bogani <alessio.bogani@...ttra.eu>
Cc:	Kumar Gala <galak@...nel.crashing.org>,
	linuxppc-dev@...ts.ozlabs.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] powerpc/86xx: Add support for Emerson/Artesyn
 MVME7100

On Tue, 2016-04-19 at 10:33 +0200, Alessio Igor Bogani wrote:
> Hi Scott,
> 
> Thanks for reviewing it!
> 
> On 19 April 2016 at 06:26, Scott Wood <oss@...error.net> wrote:
> > On Mon, 2016-04-18 at 09:57 +0200, Alessio Igor Bogani wrote:
> > > +     pci0: pcie@...08000 {
> > > +             reg = <0xf1008000 0x1000>;
> > > +             ranges = <0x02000000 0x0 0x80000000 0x80000000 0x0
> > > 0x50000000
> > > +                       0x01000000 0x0 0x00000000 0xf0000000 0x0
> > > 0x00800000>;
> [...]
> > > +
> > > +     pci1: pcie@...09000 {
> > > +             compatible = "fsl,mpc8641-pcie";
> > > +             device_type = "pci";
> > > +             #size-cells = <2>;
> > > +             #address-cells = <3>;
> > > +             reg = <0xf1009000 0x1000>;
> > > +             bus-range = <0 0xff>;
> > 
> > Why are pci0 and pci1 so different? Why does mpc8641si-post.dtsi not have
> > pci1?
> 
> You are right. The MPC8641 processor offers two pci so
> mpc8641si-post.dtsi should be the right place where to define both.
> What about the boards which don't use the pci1? Will 'status =
> "disabled"' be enough?

Yes.

-Scott