linux-kernel - Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160419221349.GA25916@rob-hp-laptop>
Date:	Tue, 19 Apr 2016 17:13:49 -0500
From:	Rob Herring <robh@...nel.org>
To:	Andreas Färber <afaerber@...e.de>
Cc:	linux-input@...r.kernel.org, Heiko Stuebner <heiko@...ech.de>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Julien Chauveau <chauveau.julien@...il.com>,
	Javier Martinez Canillas <javier@...hile0.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example

On Wed, Mar 16, 2016 at 12:53:29PM +0100, Andreas Färber wrote:
> Drop #address-cells and #size-cells, which are not required by the
> gpio-keys binding documentation, as button sub-nodes are not devices.
> 
> Rename sub-nodes to avoid new dtc unit address warnings when copied.
> 
> While at it, adopt the dashes convention for the node name.
> 
> Reported-by: Julien Chauveau <chauveau.julien@...il.com>
> Cc: Julien Chauveau <chauveau.julien@...il.com>
> Cc: Javier Martinez Canillas <javier@...hile0.org>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Andreas Färber <afaerber@...e.de>

Applied, thanks.

Rob

> ---
>  v1 -> v2:
>  * Changed node name from underscore to dash
>  * Inserted white lines
>  * Renamed sub-nodes (Geert, Julien)
>  
>  Documentation/devicetree/bindings/input/gpio-keys.txt | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
> index 21641236c095..a94940481e55 100644
> --- a/Documentation/devicetree/bindings/input/gpio-keys.txt
> +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
> @@ -32,17 +32,17 @@ Optional subnode-properties:
>  
>  Example nodes:
>  
> -	gpio_keys {
> +	gpio-keys {
>  			compatible = "gpio-keys";
> -			#address-cells = <1>;
> -			#size-cells = <0>;
>  			autorepeat;
> -			button@21 {
> +
> +			up {
>  				label = "GPIO Key UP";
>  				linux,code = <103>;
>  				gpios = <&gpio1 0 1>;
>  			};
> -			button@22 {
> +
> +			down {
>  				label = "GPIO Key DOWN";
>  				linux,code = <108>;
>  				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> -- 
> 2.6.2
>