linux-kernel - Re: [PATCH] rtc: ds1307: Use irq when available for wakeup-source device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160419225655.GJ29844@piout.net>
Date:	Wed, 20 Apr 2016 00:56:55 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Nishanth Menon <nm@...com>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Michael Lange <linuxstuff@...aw.biz>
Subject: Re: [PATCH] rtc: ds1307: Use irq when available for wakeup-source
 device

On 19/04/2016 at 11:23:54 -0500, Nishanth Menon wrote :
> With commit 8bc2a40730ec ("rtc: ds1307: add support for the
> DT property 'wakeup-source'") we lost the ability for rtc irq
> functionality for devices that are actually hooked on a real IRQ
> line and have capability to wakeup as well. This is not an expected
> behavior. So, instead of just not requesting IRQ, skip the IRQ
> requirement only if interrupts are not defined for the device.
> 
> Fixes: 8bc2a40730ec ("rtc: ds1307: add support for the DT property 'wakeup-source'")
> Reported-by: Tony Lindgren <tony@...mide.com>
> Cc: Michael Lange <linuxstuff@...aw.biz>
> Cc: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
> 
>  drivers/rtc/rtc-ds1307.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com