linux-kernel - Re: [Intel-wired-lan] [PATCH net-next V5 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1461133482.2923.28.camel@intel.com>
Date:	Tue, 19 Apr 2016 23:24:42 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>, davem@...emloft.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, olaf@...fle.de, apw@...onical.com,
	jasowang@...hat.com, eli@...lanox.com, jackm@...lanox.com,
	yevgenyp@...lanox.com, john.ronciak@...el.com,
	intel-wired-lan@...ts.osuosl.org, alexander.duyck@...il.com
Subject: Re: [Intel-wired-lan] [PATCH net-next V5 2/2] intel: ixgbevf:
 Support Windows hosts (Hyper-V)

On Tue, 2016-04-19 at 19:17 -0700, K. Y. Srinivasan wrote:
> On Hyper-V, the VF/PF communication is a via software mediated path
> as opposed to the hardware mailbox. Make the necessary
> adjustments to support Hyper-V.
> 
> Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> ---
>         V2: Addressed most of the comments from
>             Alexander Duyck <alexander.duyck@...il.com>
>             and Rustad, Mark D <mark.d.rustad@...el.com>.
> 
>         V3: Addressed additional comments from
>             Alexander Duyck <alexander.duyck@...il.com>
> 
>         V4: Addressed kbuild errors reported by:
>             kbuild test robot <lkp@...el.com>
> 
>         V5: Addressed additional comments from
>             Alexander Duyck <alexander.duyck@...il.com>

First I commend you on actually making a proper changelog for a patch.
 The only issue I have is that the changelog provides not actual
changes.  Saying you reacted to comments does not summarize what the
actual changes were.  I purposely did not review the earlier versions
because by the time I went to do a review, there was another version
already submitted.  So your changelog requires that users look at all
the previous emails to actually see what Alex and Mark requested in
changes.

I am telling you this for future patches, it will not impact these
patches, just really disappointing.  I will take the extra time to
track down all the previous emails and the changes requested to ensure
you made all the changes that were requested of you. :-(  This will
just delay when I apply the patches for testing.

> 
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf.h      |   12 ++
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c |   31 +++-
>  drivers/net/ethernet/intel/ixgbevf/mbx.c          |   12 ++
>  drivers/net/ethernet/intel/ixgbevf/vf.c           |  216
> +++++++++++++++++++++
>  drivers/net/ethernet/intel/ixgbevf/vf.h           |    2 +
>  5 files changed, 266 insertions(+), 7 deletions(-)

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)