linux-kernel - Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160420111730.GL2510@phenom.ffwll.local>
Date:	Wed, 20 Apr 2016 13:17:30 +0200
From:	Daniel Vetter <daniel@...ll.ch>
To:	"Luis R. Rodriguez" <mcgrof@...nel.org>
Cc:	Chris Wilson <chris@...is-wilson.co.uk>,
	David Airlie <airlied@...ux.ie>, netdev@...r.kernel.org,
	intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...nel.org>,
	"Peter Zijlstra (Intel)" <peterz@...radead.org>,
	dri-devel@...ts.freedesktop.org, linux-rdma@...r.kernel.org,
	Daniel Vetter <daniel.vetter@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Yishai Hadas <yishaih@...lanox.com>,
	David Hildenbrand <dahi@...ux.vnet.ibm.com>
Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move ioremap_wc tracking onto
 VMA

On Wed, Apr 20, 2016 at 11:10:54AM +0200, Luis R. Rodriguez wrote:
> Reason I ask is since I noticed a while ago a lot of drivers
> were using info->fix.smem_start and info->fix.smem_len consistently
> for their ioremap'd areas it might make sense instead to let the
> internal framebuffer (register_framebuffer()) optionally manage the
> ioremap_wc() for drivers, given that this is pretty generic stuff.

All that legacy fbdev stuff is just for legacy support, and I prefer to
have that as dumb as possible. There's been some discussion even around
lifting the "kick out firmware fb driver" out of fbdev, since we'd need it
to have a simple drm driver for e.g. uefi.

But I definitely don't want a legacy horror show like fbdev to
automagically take care of device mappings for drivers.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch