linux-kernel - Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAVeFuLdaHhfYxDgPCE3joLRXkZMfDGOzEoDwGNy1bfcQTpw3Q@mail.gmail.com>
Date:	Wed, 20 Apr 2016 10:16:15 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle
 for gpio driver

On Mon, Apr 18, 2016 at 5:46 PM, Laxman Dewangan <ldewangan@...dia.com> wrote:
> Remove the file static device handle variable as this is just
> required for prints. The required handle can be stored in
> tegra_gpio_chip and hence it become redundancy.

Small but still worthy change. "dev" in the file's global namespace is
scary and prone to conflict with local variables declarations.

Acked-by: Alexandre Courbot <acourbot@...dia.com>

Now I hope you will take care of "regs" and the other static variables
as Stephen rightfully suggested. :)