linux-kernel - Re: [PATCH net-next] net: dsa: remove tag_protocol from dsa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Apr 2016 16:39:23 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...oirfairelinux.com,
	"David S. Miller" <davem@...emloft.net>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next] net: dsa: remove tag_protocol from dsa_switch

On Mon, Apr 18, 2016 at 06:24:04PM -0400, Vivien Didelot wrote:
> Having the tag protocol in dsa_switch_driver for setup time and in
> dsa_switch_tree for runtime is enough. Remove dsa_switch's one.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

I had to think about this one for a minute. At the moment it is good,
however, sometime in the future, we might want to revert it. Some
Marvell switches support two tagging schemes. At the moment, we have
no way to express that, so the switch driver only offers one. If we
were to extend the API to express a list of supported tagging schemes,
we would then want dsa_switch to contain the scheme actually chosen.
However, until we actually implement something like this, lets remove
it.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

	     Andrew

> ---
>  include/net/dsa.h | 5 -----
>  net/dsa/dsa.c     | 5 ++---
>  2 files changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/include/net/dsa.h b/include/net/dsa.h
> index c4bc42b..2d280ab 100644
> --- a/include/net/dsa.h
> +++ b/include/net/dsa.h
> @@ -136,11 +136,6 @@ struct dsa_switch {
>  	void *priv;
>  
>  	/*
> -	 * Tagging protocol understood by this switch
> -	 */
> -	enum dsa_tag_protocol	tag_protocol;
> -
> -	/*
>  	 * Configuration data for this switch.
>  	 */
>  	struct dsa_chip_data	*pd;
> diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
> index efa612f..d61ceed 100644
> --- a/net/dsa/dsa.c
> +++ b/net/dsa/dsa.c
> @@ -267,7 +267,7 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, struct device *parent)
>  	 * switch.
>  	 */
>  	if (dst->cpu_switch == index) {
> -		switch (ds->tag_protocol) {
> +		switch (drv->tag_protocol) {
>  #ifdef CONFIG_NET_DSA_TAG_DSA
>  		case DSA_TAG_PROTO_DSA:
>  			dst->rcv = dsa_netdev_ops.rcv;
> @@ -295,7 +295,7 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, struct device *parent)
>  			goto out;
>  		}
>  
> -		dst->tag_protocol = ds->tag_protocol;
> +		dst->tag_protocol = drv->tag_protocol;
>  	}
>  
>  	/*
> @@ -411,7 +411,6 @@ dsa_switch_setup(struct dsa_switch_tree *dst, int index,
>  	ds->pd = pd;
>  	ds->drv = drv;
>  	ds->priv = priv;
> -	ds->tag_protocol = drv->tag_protocol;
>  	ds->master_dev = host_dev;
>  
>  	ret = dsa_switch_setup_one(ds, parent);
> -- 
> 2.8.0
>