linux-kernel - Re: [PATCH] sparc64: recognize and support Sonoma CPU type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5717A7FC.3000109@oracle.com>
Date:	Wed, 20 Apr 2016 10:02:04 -0600
From:	Khalid Aziz <khalid.aziz@...cle.com>
To:	Allen Pais <allen.pais@...cle.com>
Cc:	Rob Gardner <rob.gardner@...cle.com>,
	David Miller <davem@...emloft.net>,
	David Aldridge <david.j.aldridge@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	khalid@...ehiking.org,
	"sparclinux@...r.kernel.org" <sparclinux@...r.kernel.org>,
	Nitin Gupta <nitin.m.gupta@...cle.com>
Subject: Re: [PATCH] sparc64: recognize and support Sonoma CPU type

On 04/20/2016 09:54 AM, Allen Pais wrote:
>>
>> Signed-off-by: Khalid Aziz <khalid.aziz@...cle.com <mailto:khalid.aziz@...cle.com>>
>> ---
>>   arch/sparc/include/asm/spitfire.h | 1 +
>>   arch/sparc/kernel/cpu.c           | 6 ++++++
>>   arch/sparc/kernel/cpumap.c        | 1 +
>>   arch/sparc/kernel/head_64.S       | 8 ++++++++
>>   arch/sparc/kernel/setup_64.c      | 7 ++++++-
>>   arch/sparc/mm/init_64.c           | 3 +++
>>   6 files changed, 25 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/sparc/include/asm/spitfire.h b/arch/sparc/include/asm/spitfire.h
>> index 56f9338..1d8321c 100644
>> --- a/arch/sparc/include/asm/spitfire.h
>> +++ b/arch/sparc/include/asm/spitfire.h
>> @@ -48,6 +48,7 @@
>>   #define SUN4V_CHIP_SPARC_M6    0x06
>>   #define SUN4V_CHIP_SPARC_M7    0x07
>>   #define SUN4V_CHIP_SPARC64X    0x8a
>> +#define SUN4V_CHIP_SPARC_SN    0x8b
>>   #define SUN4V_CHIP_UNKNOWN     0xff
>
> Looks good to me. Do you think adding these also this patch makes sense or
> it could be a separate patch.
>
>          }
> -       if (!strcmp(sparc_pmu_type, "sparc-m7")) {
> +       if (!strcmp(sparc_pmu_type, "sparc-m7") ||
> +           !strcmp(sparc_pmu_type, "sparc-sn")) {
>                  sparc_pmu = &sparc_m7_pmu;
>                  return true;
>
> Acked-by: Allen Pais <allen.pais@...cle.com>
>
> - Allen
>

I would recommend that to be a separate patch. My goal with this patch 
is to address the core capabilities of sonoma and enable kernel to get 
optimized performance from the processor. Monitoring the performance can 
be a separate patch.

--
Khalid