linux-kernel - Re: [PATCH] cpuidle: Change ktime_get() with local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160420164748.GL5862@linaro.org>
Date:	Wed, 20 Apr 2016 18:47:48 +0200
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	rjw@...ysocki.net, mingo@...nel.org,
	"open list:CPUIDLE DRIVERS" <linux-pm@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpuidle: Change ktime_get() with local_clock()

On Wed, Apr 20, 2016 at 02:58:37PM +0200, Peter Zijlstra wrote:
> On Wed, Apr 20, 2016 at 02:30:11PM +0200, Daniel Lezcano wrote:
> > On Wed, Apr 20, 2016 at 02:13:15PM +0200, Peter Zijlstra wrote:
> > > On Thu, Apr 14, 2016 at 09:23:54PM +0200, Daniel Lezcano wrote:
> > > > @@ -217,7 +217,11 @@ int cpuidle_enter_state(struct cpuidle_device *dev, struct cpuidle_driver *drv,
> > > >  	if (!cpuidle_state_is_coupled(drv, entered_state))
> > > >  		local_irq_enable();
> > > >  
> > > > -	diff = ktime_to_us(ktime_sub(time_end, time_start));
> > > > +	/*
> > > > +	 * local_clock() returns the time in nanosecond, let's shift
> > > > +	 * by 10 (divide by 1024) to have microsecond based time.
> > > > +	 */
> > > > +	diff = (time_end - time_start) >> 10;
> > > 
> > > Changelog fails to explain the ramifications of this change...
> > 
> > Sorry, I don't get the point of your comment. Do you mean I should elaborate 
> > the comment above in the changelog?
> 
> Yeah, why is /1024 good enough?

Ok.

The conversion between nanosec to microsec could be done with integer 
division (div 1000) or by 10 bits shifting (div 1024).

The following table gives some results at the limits.

 ------------------------------------------
|   nsec   |   div(1000)   |   div(1024)   |
 ------------------------------------------
|   1e3    |        1 usec |      976 nsec |
 ------------------------------------------
|   1e6    |     1000 usec |      976 usec |
 ------------------------------------------
|   1e9    |  1000000 usec |   976562 usec |
 ------------------------------------------

There is a linear deviation of 2.34%. This loss of precision is acceptable 
in the context of the resulting diff which is used for statistics. These 
ones are processed to guess estimate an approximation of the duration of the 
next idle period which ends up into an idle state selection. The selection 
criteria takes into account the next duration based on large intervals, 
represented by the idle state's target residency.

The 2^10 division is enough because the approximation regarding the 1e3 
division is lost in all the approximations done for the next idle duration 
computation.

Would be this explanation sufficient ?