linux-kernel - Re: platform/chrome: cros_ec_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160420214513.GA78825@google.com>
Date:	Wed, 20 Apr 2016 14:45:13 -0700
From:	Brian Norris <briannorris@...omium.org>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Olof Johansson <olof@...om.net>, dianders@...omium.org,
	gwendal@...omium.org, linux-kernel@...r.kernel.org
Subject: Re: platform/chrome: cros_ec_dev - Populate compat_ioctl

On Thu, Apr 14, 2016 at 07:35:29PM -0700, Guenter Roeck wrote:
> compat_ioctl has to be populated for 32 bit userspace applications to work
> with 64 bit kernels.
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Tested with 32-bit user space on ARM64:

Tested-by: Brian Norris <briannorris@...omium.org>

> ---
> drivers/platform/chrome/cros_ec_dev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c
> index 6c45e0f5ba7b..903b1d8dcab7 100644
> --- a/drivers/platform/chrome/cros_ec_dev.c
> +++ b/drivers/platform/chrome/cros_ec_dev.c
> @@ -208,6 +208,9 @@ static const struct file_operations fops = {
>  	.release = ec_device_release,
>  	.read = ec_device_read,
>  	.unlocked_ioctl = ec_device_ioctl,
> +#ifdef CONFIG_COMPAT
> +	.compat_ioctl = ec_device_ioctl,
> +#endif
>  };
>  
>  static void __remove(struct device *dev)