linux-kernel - Re: [PATCH v6 08/19] i2c: octeon: Enable High-Level Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5717FAC3.6010406@caviumnetworks.com>
Date:	Wed, 20 Apr 2016 14:55:15 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	Wolfram Sang <wsa@...-dreams.de>
CC:	Jan Glauber <jglauber@...ium.com>, <linux-kernel@...r.kernel.org>,
	<linux-i2c@...r.kernel.org>
Subject: Re: [PATCH v6 08/19] i2c: octeon: Enable High-Level Controller

On 04/20/2016 02:43 PM, Wolfram Sang wrote:
> On Mon, Apr 11, 2016 at 05:28:39PM +0200, Jan Glauber wrote:
[...]
>> + */
>> +static int octeon_i2c_hlc_wait(struct octeon_i2c *i2c)
>> +{
>> +	int time_left;
>> +
>> +	octeon_i2c_hlc_int_enable(i2c);
>> +	time_left = wait_event_interruptible_timeout(i2c->queue,
>> +					octeon_i2c_hlc_test_ready(i2c),
>> +					i2c->adap.timeout);
>
> Have you tested signal handling thoroughly? Most driver dropped the
> _interruptible after a while. Mostly they found out that the state
> machine of the interrupt handler couldn't gracefully deal with it and
> nobody really needed the interruptible. Just saying.

Good point.  We know that exiting with a signal leaves us in an 
undefined state.

We will have to think on this point.


>
>> +	octeon_i2c_int_disable(i2c);
>> +	if (!time_left) {
>> +		octeon_i2c_hlc_int_clear(i2c);
>> +		dev_dbg(i2c->dev, "%s: timeout\n", __func__);
>> +		return -ETIMEDOUT;
>> +	}
>> +
>> +	if (time_left < 0) {
>> +		dev_dbg(i2c->dev, "%s: wait interrupted\n", __func__);
>> +		return time_left;
>> +	}
>> +	return 0;
>> +}
>
> Drop the debug messages?
>
> I can't say much about the HW details, of course. Didn't spot anything
> suspicious there.
>