linux-kernel - Re: [PATCH mmotm 4/5] huge tmpfs: avoid premature exposure of new pagetable revert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Apr 2016 09:55:55 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Hugh Dickins <hughd@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Andres Lagar-Cavilla <andreslc@...gle.com>,
	Yang Shi <yang.shi@...aro.org>, Ning Qu <quning@...il.com>,
	kernel test robot <xiaolong.ye@...el.com>,
	Xiong Zhou <jencce.kernel@...il.com>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Greg Thelen <gthelen@...gle.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH mmotm 4/5] huge tmpfs: avoid premature exposure of new
 pagetable revert

Hi Hugh,

On Sat, 16 Apr 2016 16:38:15 -0700 (PDT) Hugh Dickins <hughd@...gle.com> wrote:
>
> This patch reverts all of my 09/31, your
> huge-tmpfs-avoid-premature-exposure-of-new-pagetable.patch
> and also the mm/memory.c changes from the patch after it,
> huge-tmpfs-map-shmem-by-huge-page-pmd-or-by-page-team-ptes.patch
> 
> I've diffed this against the top of the tree, but it may be better to
> throw this and huge-tmpfs-avoid-premature-exposure-of-new-pagetable.patch
> away, and just delete the mm/memory.c part of the patch after it.
> 
> This is in preparation for 5/5, which replaces what was done here.
> Why?  Numerous reasons.  Kirill was concerned that my movement of
> map_pages from before to after fault would show performance regression.
> Robot reported vm-scalability.throughput -5.5% regression, bisected to
> the avoid premature exposure patch.  Andrew was concerned about bloat
> in mm/memory.o.  Google had seen (on an earlier kernel) an OOM deadlock
> from pagetable allocations being done while holding pagecache pagelock.
> 
> I thought I could deal with those later on, but the clincher came from
> Xiong Zhou's report that it had broken binary execution from DAX mount.
> Silly little oversight, but not as easily fixed as first appears, because
> DAX now uses the i_mmap_rwsem to guard an extent from truncation: which
> would be open to deadlock if pagetable allocation goes down to reclaim
> (both are using only the read lock, but in danger of an rwr sandwich).
> 
> I've considered various alternative approaches, and what can be done
> to get both DAX and huge tmpfs working again quickly.  Eventually
> arrived at the obvious: shmem should use the new pmd_fault().
> 
> Reported-by: kernel test robot <xiaolong.ye@...el.com>
> Reported-by: Xiong Zhou <jencce.kernel@...il.com>
> Signed-off-by: Hugh Dickins <hughd@...gle.com>
> ---
>  mm/filemap.c |   10 --
>  mm/memory.c  |  225 +++++++++++++++++++++----------------------------
>  2 files changed, 101 insertions(+), 134 deletions(-)

I added this at the end of mmotm in linux-next today.  I will leave
Andrew to sort it out later.

-- 
Cheers,
Stephen Rothwell