linux-kernel - Re: [PATCH] char: Drop bogus dependency of DEVPORT on !M68K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1461230117.2533.8.camel@tiscali.nl>
Date:	Thu, 21 Apr 2016 11:15:17 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	ahs3@...hat.com, Geert Uytterhoeven <geert@...ux-m68k.org>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Geoff Levand <geoff@...radead.org>, linux-kernel@...r.kernel.org,
	linux-m68k@...r.kernel.org
Subject: Re: [PATCH] char: Drop bogus dependency of DEVPORT on !M68K

On wo, 2016-04-20 at 13:43 -0600, Al Stone wrote:
> On 04/11/2016 02:40 AM, Geert Uytterhoeven wrote:
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig

> > config DEVPORT
> >  	bool
> > -	depends on !M68K
> >  	depends on ISA || PCI
> >  	default y

> This solves the particular problem I was running into on an arm64 AMD Seattle
> system.  Thanks!

That problem must be 
lkml.kernel.org/g/1459978040-2226-1-git-send-email-ahs3@...hat.com . Ie,
the fact that CONFIG_DEVPORT "cannot really be used and it allows us to
crash a kernel from user space" on arm64. 

> Tested-by: Al Stone <ahs3@...hat.com>

I fail to see how this patch helps your problem. And if one applies this
patch on top of v4.6-rc4 and does
    make ARCH=arm64 defconfig

one gets a .config that still has
    CONFIG_DEVPORT=y

So my guess is that it wasn't this patch that solved that arm64 problem.

Thanks,


Paul Bolle