linux-kernel - Re: [PATCH v2] i2c: designware-platdrv: fix unbalanced clk enable and prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Apr 2016 14:03:34 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Jisheng Zhang <jszhang@...vell.com>, jarkko.nikula@...ux.intel.com,
	mika.westerberg@...ux.intel.com, wsa@...-dreams.de
Cc:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] i2c: designware-platdrv: fix unbalanced clk enable
 and prepare

On Thu, 2016-04-21 at 17:26 +0800, Jisheng Zhang wrote:
> If i2c_dw_probe() fail, we should disable and unprepare the clk,

clk -> clock, or use function name explicitly.

> otherwise the clk enable and prepare is left unbalanced.
> 

Ditto.

> In dw_i2c_plat_remove(), we'd better to not rely on rpm to disable
> and unprepare the clk since CONFIG_PM may be disabled when configuring

Ditto.

> the kernel. So we explicitly disable and unprepare the clk in

Ditto.

> dw_i2c_plat_remove().


> +	pm_runtime_put_noidle(&pdev->dev);
>  
> -	pm_runtime_put_sync(&pdev->dev);
> 

This change also needs to be described in the commit message.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy