linux-kernel - [PATCH] mfd: smsc-ece1099: Remove unnecessarily remove callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1461240939-21110-1-git-send-email-ldewangan@nvidia.com>
Date:	Thu, 21 Apr 2016 17:45:39 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	<lee.jones@...aro.org>
CC:	<linux-kernel@...r.kernel.org>,
	Laxman Dewangan <ldewangan@...dia.com>,
	Benoit Cousson <b-cousson@...com>, Felipe Balbi <balbi@...com>,
	"Santosh Shilimkar" <santosh.shilimkar@...com>,
	Sourav Poddar <sourav.poddar@...com>
Subject: [PATCH] mfd: smsc-ece1099: Remove unnecessarily remove callback

SMSC MFD driver does not add any MFD child devices via
mfd_add_devices() and hence it is not required to call
mfd_remove_devices() to remove MFD child devices.

Remove the call of the API mfd_remove_devices() which will
result as remove of .remove callback for driver.

Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
Cc: Benoit Cousson <b-cousson@...com>
Cc: Felipe Balbi <balbi@...com>
Cc: Santosh Shilimkar <santosh.shilimkar@...com>
Signed-off-by: Sourav Poddar <sourav.poddar@...com>
---
This is build and compile tested only.

 drivers/mfd/smsc-ece1099.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c
index a4c0df7..7f89e89 100644
--- a/drivers/mfd/smsc-ece1099.c
+++ b/drivers/mfd/smsc-ece1099.c
@@ -80,15 +80,6 @@ err:
 	return ret;
 }
 
-static int smsc_i2c_remove(struct i2c_client *i2c)
-{
-	struct smsc *smsc = i2c_get_clientdata(i2c);
-
-	mfd_remove_devices(smsc->dev);
-
-	return 0;
-}
-
 static const struct i2c_device_id smsc_i2c_id[] = {
 	{ "smscece1099", 0},
 	{},
@@ -100,7 +91,6 @@ static struct i2c_driver smsc_i2c_driver = {
 		   .name = "smsc",
 	},
 	.probe = smsc_i2c_probe,
-	.remove = smsc_i2c_remove,
 	.id_table = smsc_i2c_id,
 };
 
-- 
2.1.4