linux-kernel - Re: [PATCH] x86/efi: Remove the always true EFI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160421124820.GF2829@codeblueprint.co.uk>
Date:	Thu, 21 Apr 2016 13:48:20 +0100
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Borislav Petkov <bp@...en8.de>
Cc:	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Robert Elliott <elliott@....com>
Subject: Re: [PATCH] x86/efi: Remove the always true EFI_DEBUG symbol

On Thu, 21 Apr, at 02:45:42PM, Borislav Petkov wrote:
> On Thu, Apr 21, 2016 at 12:09:30PM +0100, Matt Fleming wrote:
> > This symbol is always set which makes it useless. Additionally we have
> > a kernel command-line switch, efi=debug, which actually controls the
> > printing of the memory map.
> > 
> > Reported-by: Robert Elliott <elliott@....com>
> > Cc: Borislav Petkov <bp@...en8.de>
> > Signed-off-by: Matt Fleming <matt@...eblueprint.co.uk>
> > ---
> >  arch/x86/platform/efi/efi.c | 4 ----
> >  1 file changed, 4 deletions(-)
> 
> Acked-by: Borislav Petkov <bp@...e.de>
> 
> Btw, there's also
> 
> arch/ia64/kernel/efi.c:45:#define EFI_DEBUG     0
> arch/ia64/kernel/efi.c:399:#if EFI_DEBUG
> arch/ia64/kernel/efi.c:559:#if EFI_DEBUG
> 
> I'm assuming you want to put that behind "if (efi_enabled(EFI_DBG))" too...

Hmm.. Yes, that'd be a good idea. I am in the process of setting up an
Itanium box or two for runtime EFI testing, so I'll make a note of
this task.