linux-kernel - Re: [PATCH v11 0/3] printk: Make printk() completely async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160421131925.GA30087@quack2.suse.cz>
Date:	Thu, 21 Apr 2016 15:19:25 +0200
From:	Jan Kara <jack@...e.cz>
To:	Joe Perches <joe@...ches.com>
Cc:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jan Kara <jack@...e.com>, Petr Mladek <pmladek@...e.com>,
	Tejun Heo <tj@...nel.org>,
	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	linux-kernel@...r.kernel.org,
	Byungchul Park <byungchul.park@....com>,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH v11 0/3] printk: Make printk() completely async

On Wed 20-04-16 19:17:13, Joe Perches wrote:
> On Thu, 2016-04-21 at 11:14 +0900, Sergey Senozhatsky wrote:
> > On (04/15/16 22:44), Joe Perches wrote:
> > [..]
> > > > Sir, is there anything else you want me to improve in this patch
> > > > set?
> > > I'm not sir, but my preference would be to move as much of the
> > > async/thread functionality as possible into a separate file.
> > hm, we are talking about some 50-60 lines of code in total (seems
> > that the patch set adds more comments than code), but your point
> > is interesting. let's say, if there will be more opinions that it
> > better land in async_printk.{c,h} files, then I'll take a look on
> > it. how does it sound?
> 
> I think printk.c is pretty large, complicated and should
> be broken up into several bits.
> 
> I did that once, but it's a real development timing issue 
> https://lkml.org/lkml/2012/10/17/41

As much as that may be a useful excercise, I don't think it really belongs
in this rather small patch set.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR