linux-kernel - Re: [PATCH] OMAPDSS: HDMI5: Fix AVI infoframe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5718E726.4020504@ti.com>
Date:	Thu, 21 Apr 2016 17:43:50 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	"J.D. Schroeder" <Linux.HWI@...min.com>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<linux-fbdev@...r.kernel.org>, <misael.lopez@...com>
CC:	"Lodes, Jim" <jim.lodes@...min.com>,
	"J.D. Schroeder" <jay.schroeder@...min.com>
Subject: Re: [PATCH] OMAPDSS: HDMI5: Fix AVI infoframe

Hi,

On 21/04/16 16:48, J.D. Schroeder wrote:
> From: "Lodes, Jim" <jim.lodes@...min.com>
> 
> The AVI infoframe R0-R3 in the 2nd data byte represents the
> Active Format Aspect Ratio. It is four bits long not two bits.
> This fixes that mask used to extract the bits before writing the
> bits to the hardware registers.
> 
> Signed-off-by: Lodes, Jim <jim.lodes@...min.com>
> Signed-off-by: J.D. Schroeder <jay.schroeder@...min.com>

Thanks, looks good. Can you fix the email here too, and resend?

 Tomi

>  drivers/gpu/drm/omapdrm/dss/hdmi5_core.c          | 2 +-
>  drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
> index d993f78..8ab2093 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.c
> @@ -458,7 +458,7 @@ static void hdmi_core_write_avi_infoframe(struct hdmi_core_data *core,
>  
>  	c = (ptr[1] >> 6) & 0x3;
>  	m = (ptr[1] >> 4) & 0x3;
> -	r = (ptr[1] >> 0) & 0x3;
> +	r = (ptr[1] >> 0) & 0xf;
>  
>  	itc = (ptr[2] >> 7) & 0x1;
>  	ec = (ptr[2] >> 4) & 0x7;
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
> index f3e4b81..bbfe7e2 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
> @@ -442,7 +442,7 @@ static void hdmi_core_write_avi_infoframe(struct hdmi_core_data *core,
>  
>  	c = (ptr[1] >> 6) & 0x3;
>  	m = (ptr[1] >> 4) & 0x3;
> -	r = (ptr[1] >> 0) & 0x3;
> +	r = (ptr[1] >> 0) & 0xf;
>  
>  	itc = (ptr[2] >> 7) & 0x1;
>  	ec = (ptr[2] >> 4) & 0x7;
> 



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)