linux-kernel - Re: [PATCH v2] regulator: core: Add debugfs to show constraint flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160421150656.GP3217@sirena.org.uk>
Date:	Thu, 21 Apr 2016 16:06:56 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:	lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH v2] regulator: core: Add debugfs to show constraint flags

On Thu, Apr 21, 2016 at 01:36:14PM +0100, Richard Fitzgerald wrote:

> +	ret = snprintf(buf, PAGE_SIZE,
> +		"always_on: %u\nboot_on: %u\napply_uV: %u\nramp_disable: %u\n"
> +		"soft_start: %u\npull_down: %u\nover_current_protection: %u\n",
> +		!!c->always_on,
> +		!!c->boot_on,
> +		!!c->apply_uV,
> +		!!c->ramp_disable,
> +		!!c->soft_start,
> +		!!c->pull_down,
> +		!!c->over_current_protection);

Can we try for legibility please?  Trying to cram everything onto the
minimum number of lines really doesn't help and the !!s either do
nothing or will end up obscuring information down the line.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)