[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160421152456.GA8087@rob-hp-laptop>
Date: Thu, 21 Apr 2016 10:24:56 -0500
From: Rob Herring <robh@...nel.org>
To: Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc: Herbert Xu <herbert@...dor.apana.org.au>,
"David S. Miller" <davem@...emloft.net>,
Vladimir Zapolskiy <vz@...ia.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH 2/2] crypto: s5p-sss - Remove useless hash interrupt
handler
On Tue, Apr 19, 2016 at 03:44:12PM +0200, Krzysztof Kozlowski wrote:
> Beside regular feed control interrupt, the driver requires also hash
> interrupt for older SoCs (samsung,s5pv210-secss). However after
> requesting it, the interrupt handler isn't doing anything with it, not
> even clearing the hash interrupt bit.
>
> Driver does not provide hash functions so it is safe to remove the hash
> interrupt related code and to not require the interrupt in Device Tree.
NAK for the DT change. If the h/w has a 2nd interrupt, then it should be
defined. Whether the driver uses it or not is a driver problem.
Rob
Powered by blists - more mailing lists